-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to 9.0.1 #32291
Upgrade EUI to 9.0.1 #32291
Conversation
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from APM 👍
@maryia-lapata doh, I've been working with the EUI team to get Kibana upgraded to EUI@latest here: #32009 ... makes no difference to me which PR we keep open but I think I'm down to one error in mine. :) |
💔 Build Failed |
@maryia-lapata do you mind if we close this so that we don't accidentally have two of us continuing to work on this moving forward? Or if you are making progress on the |
@jasonrhodes unfortunately I haven't made any progress on the |
Summary
Upgrade EUI from 7.1.0 -> 9.0.1
9.0.1
Bug fixes
9.0.0
allowNeutralSort
prop toEuiInMemoryTable
to support unsorting table columns (#1591)mobileOptions
object prop for handling of all the mobile specific options ofEuiBasicTable
(#1462)React.node
types (#1462)displayOnly
prop toEuiFormRow
(#1582)numActiveFilters
prop toEuiFilterButton
(#1589)EuiFilterButton
to matchEuiFacetButton
(#1589)EuiNotificationBadge
(#1589)EuiDescribedFormGroup
to exist as a description-only row (#1522)type
prop forEuiFormLabel
for the option to make it a legend (#1613)labelAppend
andlabelType
props toEuiFormRow
(#1613)EuiModalBody
,EuiModalFooter
,EuiModalHeader
,EuiModalHeaderTitle
,EuiFlyoutBody
,EuiFlyoutFooter
,EuiFlyoutHeader
,EuiPortal
, andEuiProgress
to Typescript (use the buildNum to bust require.js cache, fixes #1574 #1621#1633)Bug fixes
EuiComboBox
items in single selection mode (#1619)EuiBasicTable
select all shows up on mobile (#1462)hasActiveFilters
prop forEuiFilterButton
type and fixesonChange
signature forEuiButtonGroup
(#1603)react-datepicker
TS types in EUI itself to avoid outside dependency (#1618)EuiGlobalToastList
from attempting calculations on null DOM elements (#1606)EuiFormRow
errors from the possibility of having duplicate key values (#1522)Breaking changes
EuiBasicTable's
select all checkbox appends a makeId string to the id (#1462)@types/react-dom
topeerDependencies
(#1621)8.0.0
Breaking changes
7.3.0
onRefresh
option forEuiSuperDatePicker
(#1577)EuiToggle
toTypeScript
(#1570)EuiButtonGroup
,EuiButtonToggle
,EuiFilterButton
,EuiFilterGroup
, andEuiFilterSelectItem
(#1570)displayOnly
prop toEuiFormRow
(#1582)index.d.ts
file for the date picker components, includingEuiDatePicker
,EuiDatePickerRange
, andEuiSuperDatePicker
(#1574)Bug fixes
EuiRange
andEuiDualRange
including sizing of inputs, tick placement, and the handling of invalid values (#1580)7.2.0
EuiLink
(#1571)EuiResizeObserver
to exposeResizeObserver
API to React components; falls back toMutationObserver
API in unsupported browsers (#1559)EuiFocusTrap
as a wrapper around react-focus-lock to enable trapping focus in more cases, including React portals (#1550)Bug fixes
EuiContextMenuPanel
when height changes dynamically (#1559)EuiComboBox
to allow keyboard tab to exit single selection box (#1576)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately