Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to 9.0.1 #32291

Closed

Conversation

maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented Mar 1, 2019

Summary

Upgrade EUI from 7.1.0 -> 9.0.1

9.0.1

Bug fixes

  • Fixed definition exports for converted Typescript components (#1633)

9.0.0

  • Added allowNeutralSort prop to EuiInMemoryTable to support unsorting table columns (#1591)
  • Added mobileOptions object prop for handling of all the mobile specific options of EuiBasicTable (#1462)
  • Table headers now accept React.node types (#1462)
  • Added displayOnly prop to EuiFormRow (#1582)
  • Added numActiveFilters prop to EuiFilterButton (#1589)
  • Updated style of EuiFilterButton to match EuiFacetButton (#1589)
  • Added size and color props to EuiNotificationBadge (#1589)
  • Allow EuiDescribedFormGroup to exist as a description-only row (#1522)
  • Added type prop for EuiFormLabel for the option to make it a legend (#1613)
  • Added labelAppend and labelType props to EuiFormRow (#1613)
  • Aligned text styles of table headers and form labels (#1613)
  • Converted EuiModalBody, EuiModalFooter, EuiModalHeader, EuiModalHeaderTitle, EuiFlyoutBody, EuiFlyoutFooter, EuiFlyoutHeader, EuiPortal, and EuiProgress to Typescript (use the buildNum to bust require.js cache, fixes #1574 #1621#1633)

Bug fixes

  • Fixed keyboard navigation and UI of EuiComboBox items in single selection mode (#1619)
  • EuiBasicTable select all shows up on mobile (#1462)
  • Adds missing hasActiveFilters prop for EuiFilterButton type and fixes onChange signature for EuiButtonGroup (#1603)
  • Included react-datepicker TS types in EUI itself to avoid outside dependency (#1618)
  • Prevent EuiGlobalToastList from attempting calculations on null DOM elements (#1606)
  • Fixed EuiFormRow errors from the possibility of having duplicate key values (#1522)

Breaking changes

  • EuiBasicTable's select all checkbox appends a makeId string to the id (#1462)
  • Remove camel casing from exported JSON variables and preserve hex values instead of converting to rgb (#1590)
  • Added @types/react-dom to peerDependencies (#1621)

8.0.0

Breaking changes

  • Upgraded TypeScript to 3.3 (#1583)
  • Upgraded React to 16.8 (#1583)
  • Upgraded Jest to 24.1 (#1583)
  • Upgraded Enzyme to 3.9 (#1583)

7.3.0

  • Added onRefresh option for EuiSuperDatePicker (#1577)
  • Converted EuiToggle to TypeScript (#1570)
  • Added type definitions for EuiButtonGroup, EuiButtonToggle, EuiFilterButton, EuiFilterGroup, and EuiFilterSelectItem (#1570)
  • Added displayOnly prop to EuiFormRow (#1582)
  • Added an index.d.ts file for the date picker components, including EuiDatePicker, EuiDatePickerRange, and EuiSuperDatePicker (#1574)

Bug fixes

  • Fixed several bugs with EuiRange and EuiDualRange including sizing of inputs, tick placement, and the handling of invalid values (#1580)

7.2.0

  • Added text as a color option for EuiLink (#1571)
  • Added EuiResizeObserver to expose ResizeObserver API to React components; falls back to MutationObserver API in unsupported browsers (#1559)
  • Added EuiFocusTrap as a wrapper around react-focus-lock to enable trapping focus in more cases, including React portals (#1550)

Bug fixes

  • Fixed content cut off in EuiContextMenuPanel when height changes dynamically (#1559)
  • Fixed EuiComboBox to allow keyboard tab to exit single selection box (#1576)
  • Various fixes related to focus order and focus trapping as they relate to content in React portals (#1550)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@maryia-lapata maryia-lapata requested review from a team as code owners March 1, 2019 12:12
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from APM 👍

@nreese nreese mentioned this pull request Mar 1, 2019
@jasonrhodes
Copy link
Member

@maryia-lapata doh, I've been working with the EUI team to get Kibana upgraded to EUI@latest here: #32009 ... makes no difference to me which PR we keep open but I think I'm down to one error in mine. :)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jasonrhodes
Copy link
Member

@maryia-lapata do you mind if we close this so that we don't accidentally have two of us continuing to work on this moving forward? Or if you are making progress on the <AlignedProgress bug, I can close mine, but would like to make sure we only have one open and consolidate comments and efforts.

@maryia-lapata
Copy link
Contributor Author

@jasonrhodes unfortunately I haven't made any progress on the <AlignedProgress bug.
I'll close this PR.

@maryia-lapata maryia-lapata deleted the update-eui-version branch October 21, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants